Author ncoghlan
Recipients jcon, kristjan.jonsson, mark.dickinson, ncoghlan, paul.moore, petri.lehtinen, pitrou, pv, rupole, skrah, teoliphant, vstinner
Date 2012-01-16.13:23:44
SpamBayes Score 6.69979e-06
Marked as misclassified No
Message-id <1326720225.98.0.599117190399.issue10181@psf.upfronthosting.co.za>
In-reply-to
Content
Finally reviewed Stefan's latest patch. It mostly looks great to me. Aside from a few minor cosmetic quibbles, the only substantive change I would like is to expose the Py_buffer len field as "memoryview.size" instead of "memoryview.len" (to reduce confusion with "len(memoryview)" and to encourage a conceptual link with sys.getsizeof()).

As noted in the review, I also think fixing #12384 should be fairly straightforward and it would be nice to have that working when the change is applied.

(Kristjan: I added you to the nosy list, since you commented on another issue that you had been poking around in the memoryview internals and noticed a few dodgy things. Stefan's work on this issue is aimed at comprehensively addressing those problems).
History
Date User Action Args
2012-01-16 13:23:46ncoghlansetrecipients: + ncoghlan, teoliphant, paul.moore, mark.dickinson, rupole, pitrou, kristjan.jonsson, vstinner, pv, skrah, jcon, petri.lehtinen
2012-01-16 13:23:45ncoghlansetmessageid: <1326720225.98.0.599117190399.issue10181@psf.upfronthosting.co.za>
2012-01-16 13:23:45ncoghlanlinkissue10181 messages
2012-01-16 13:23:44ncoghlancreate