This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author ronaldoussoren
Recipients Arfrever, eric.araujo, loewis, ronaldoussoren, rpq
Date 2012-01-07.10:52:33
SpamBayes Score 7.97196e-13
Marked as misclassified No
Message-id <1325933554.73.0.0307543541216.issue13511@psf.upfronthosting.co.za>
In-reply-to
Content
He's probably referring to this fragment in setup.py:


        if platform == 'darwin':
            # This should work on any unixy platform ;-)
            # If the user has bothered specifying additional -I and -L flags
            # in OPT and LDFLAGS we might as well use them here.
            #   NOTE: using shlex.split would technically be more correct, but
            # also gives a bootstrap problem. Let's hope nobody uses directories
            # with whitespace in the name to store libraries.
            cflags, ldflags = sysconfig.get_config_vars(
                    'CFLAGS', 'LDFLAGS')
            for item in cflags.split():
                if item.startswith('-I'):
                    inc_dirs.append(item[2:])
            for item in ldflags.split():
                if item.startswith('-L'):
                    lib_dirs.append(item[2:])


The entire block was added when I worked on the Mac port with Jack Jansen.  It ensures that additional include and lib directories specified through the 'OPT' and 'LDFLAGS' shell variables get added to the search path used by distutils.

As the comment says this should be safe all unity platforms, not just OSX.  IIRC the platform test is there because we couldn't easily test on other platforms and didn't want to accidentally break stuff (this was before we had a good buildbot setup).
History
Date User Action Args
2012-01-07 10:52:34ronaldoussorensetrecipients: + ronaldoussoren, loewis, eric.araujo, Arfrever, rpq
2012-01-07 10:52:34ronaldoussorensetmessageid: <1325933554.73.0.0307543541216.issue13511@psf.upfronthosting.co.za>
2012-01-07 10:52:34ronaldoussorenlinkissue13511 messages
2012-01-07 10:52:33ronaldoussorencreate