This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author eric.araujo
Recipients Low.Kian.Seong, Tigger.Level-5, eric.araujo, eric.smith, ezio.melotti, giampaolo.rodola, ncoghlan, orsenthil, pitrou, vstinner
Date 2012-01-06.16:42:41
SpamBayes Score 1.6662671e-11
Marked as misclassified No
Message-id <1325868162.49.0.798309417833.issue13033@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for the patch.  Before you do any more work, do other core developers agree that this function is a good addition or is it obsoleted by the generic improved-walk-with-callback that Nick is working on?

Doc/library/shutil.rst:

I don’t think the note directives are needed.  The doc is not big, I assume people will read all of it and see the caveats.  (I’ll also want to group some small paragraphs.)

Lib/shutil.py:

+def chowntree(path, user=None, group=None, followlinks=False):
+ [...]
+    The dictionary _modified_items, will keep track of the old ownership details,
What _modified_items dictionary?

Apart from a few stylistic violations which can be fixed by the committer, the function looks good.

Lib/test/test_shutil.py:

Looks good and needs more tests.  Currently it only calls chowntree on a directory without children, so it does not test that the chown is indeed recursive.
History
Date User Action Args
2012-01-06 16:42:42eric.araujosetrecipients: + eric.araujo, ncoghlan, orsenthil, pitrou, vstinner, eric.smith, giampaolo.rodola, ezio.melotti, Low.Kian.Seong, Tigger.Level-5
2012-01-06 16:42:42eric.araujosetmessageid: <1325868162.49.0.798309417833.issue13033@psf.upfronthosting.co.za>
2012-01-06 16:42:41eric.araujolinkissue13033 messages
2012-01-06 16:42:41eric.araujocreate