Message150720
Some review comments. Instead of doing the inline unquote like this -
- auth = base64.b64encode(user_passwd).strip()
+ auth = base64.b64encode(unquote(user_passwd)).strip()
It is better to do the explicitly above the b64 encoding step.
Just as host has been unquoted.
user_passwd, host = splituser(host)
host = unquote(host)
Also, you have done this only for https_open, the same would need be replicated for http_open and also for proxy_passwd. Also on tests, Modifying sendall with
def sendall(self, str):
- pass
+ FakeHTTPConnection.request += str
seems a bit odd to me, you are using a class level object and adding a str. I think, there should be better way to do. (I shall provide an example). Also str term can replaced, even if it was coming from old code. |
|
Date |
User |
Action |
Args |
2012-01-06 10:53:51 | orsenthil | set | recipients:
+ orsenthil, jcea, carljm, maker, joneskoo |
2012-01-06 10:53:51 | orsenthil | set | messageid: <1325847231.6.0.631468216986.issue13642@psf.upfronthosting.co.za> |
2012-01-06 10:53:51 | orsenthil | link | issue13642 messages |
2012-01-06 10:53:50 | orsenthil | create | |
|