Message150292
It's really hard to understand true, and if should not go in the patch in general of course.
The sense was that the only test I added is trivial, but I haven't produced something better yet.
And ok I will remove the docstrings, I was actually doing it on purpose thinking about the unittest feature, but if the name is clear enough than is better to leave the docstring out...
Another thing, I didn't want to use tempfile.mktemp to generate a temporary file, but dump_stats doesn't accept anything else, is it in general safe to use it in this case? |
|
Date |
User |
Action |
Args |
2011-12-28 15:36:53 | andrea.crotti | set | recipients:
+ andrea.crotti, georg.brandl, brian.curtin |
2011-12-28 15:36:53 | andrea.crotti | set | messageid: <1325086613.76.0.965276622203.issue13670@psf.upfronthosting.co.za> |
2011-12-28 15:36:53 | andrea.crotti | link | issue13670 messages |
2011-12-28 15:36:53 | andrea.crotti | create | |
|