Author neologix
Recipients Trundle, draghuram, eric.araujo, giampaolo.rodola, neologix, pitrou, r.david.murray, tarek, techtonik, vstinner
Date 2011-12-23.16:30:54
SpamBayes Score 5.24464e-12
Marked as misclassified No
Message-id <1324657855.68.0.175662338942.issue8828@psf.upfronthosting.co.za>
In-reply-to
Content
> How about overwrite=[None, True] with None meaning "OS default"?

+1.

> One of the Python advantages is providing predictable cross-platform 
> behavior. If we can't introduce nice API without BC break, it is not
> a reason to introduce ulgy API.

We cannot make rename() overwrite existing files by default (on Windows).
It's out of question, too much code might rely on this, and this may very well introduce security flaws.
If you're concerned with the semantics difference between platforms, well, there's not much we can do about it now. Java behaves in the same way, for example.

> I'm good with None/True, but that would imply that for posix rename 
> we'll need to implement the overwrite=False option...which would be a 
> nice thing (the shell mv command has -i for that).

Why?
The problem is that it's simply impossible to implement reliably.
I didn't check mv source code, but it must be using something like:

if '-i' and os.path.exists(target_path):
    continue
os.rename(src_path, target_path).

But there's a TOCTTOU race.
History
Date User Action Args
2011-12-23 16:30:55neologixsetrecipients: + neologix, pitrou, vstinner, draghuram, techtonik, giampaolo.rodola, tarek, eric.araujo, r.david.murray, Trundle
2011-12-23 16:30:55neologixsetmessageid: <1324657855.68.0.175662338942.issue8828@psf.upfronthosting.co.za>
2011-12-23 16:30:55neologixlinkissue8828 messages
2011-12-23 16:30:54neologixcreate