Author ezio.melotti
Recipients Oleg.Plakhotnyuk, ezio.melotti, r.david.murray, vstinner
Date 2011-12-13.14:11:10
SpamBayes Score 2.78458e-09
Marked as misclassified No
Message-id <1323785472.0.0.137796620778.issue13394@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for splitting the patch.
I tried to apply the patch to 3.2 and I have 3 comments:
1) you changed a commented-out assertEqual with an assertNotEqual, because "ULAW is lossy compression, so frames *may* not match".  Does it mean that sometimes they might match and make the test fail or that they are always different for this specific test?  In the first case the test should make sure to have a consistent result and avoid sporadic failures.  In the second case the check could be removed altogether, because producing different results is not a feature of the format, but just a detail that depends on the input.
2) when I run the tests I now get 3 warnings:
Warning: bad COMM chunk size
Warning: bad COMM chunk size
Warning: MARK chunk contains only 0 markers instead of 1
These should be silenced, or better, tested with self.assertWarns (assertWarns should silence them too).
3) there's some trailing space just before test_write_header_comptype_raises.
History
Date User Action Args
2011-12-13 14:11:12ezio.melottisetrecipients: + ezio.melotti, vstinner, r.david.murray, Oleg.Plakhotnyuk
2011-12-13 14:11:11ezio.melottisetmessageid: <1323785472.0.0.137796620778.issue13394@psf.upfronthosting.co.za>
2011-12-13 14:11:10ezio.melottilinkissue13394 messages
2011-12-13 14:11:10ezio.melotticreate