Author pitrou
Recipients Garen, belopolsky, danchr, dhduvall, dmalcolm, fche, glyph, hazmat, jbaker, jcea, jmcp, laca, lasizoillo, loewis, mjw, movement, neologix, pitrou, rhettinger, robert.kern, ronaldoussoren, scox, serverhorror, sirg3, techtonik, twleung, wsanchez
Date 2011-12-12.09:48:02
SpamBayes Score 0.000326837
Marked as misclassified No
Message-id <1323683283.19.0.605505674141.issue13405@psf.upfronthosting.co.za>
In-reply-to
Content
Very high-level comments on your patch:

- why an empty "dtrace" module?

- I'm worried that you're adding lots of delicate code inside critical core functions. Perhaps most of it can be factored out in separate functions living in another (dtrace-specific) C file? I don't think we really want to maintain some asm("nop") in the GC module, and I'm not even talking about the madness in ceval.c.

- instead of generating code data (line numbers etc.) up front, why not generate and cache it lazily? that way, it would only be generated when the probes are really used (IIUC)

For higher-level benchmarks, I suggest you take a look at http://hg.python.org/benchmarks/
History
Date User Action Args
2011-12-12 09:48:03pitrousetrecipients: + pitrou, loewis, rhettinger, jcea, ronaldoussoren, belopolsky, wsanchez, movement, techtonik, serverhorror, glyph, laca, twleung, jbaker, robert.kern, sirg3, danchr, dhduvall, dmalcolm, mjw, Garen, neologix, lasizoillo, fche, hazmat, jmcp, scox
2011-12-12 09:48:03pitrousetmessageid: <1323683283.19.0.605505674141.issue13405@psf.upfronthosting.co.za>
2011-12-12 09:48:02pitroulinkissue13405 messages
2011-12-12 09:48:02pitroucreate