Message148846
Hello Jon, and thanks for the patch. I have a couple of comments:
- readinto() shouldn't return None but 0 when there is nothing to read (this corresponds to read() returning b"")
- I see _read_chunked() is only ever called with amt=None, so perhaps it can be simplified?
Also, a nitpick: the doc entry needs a "versionadded" tag. |
|
Date |
User |
Action |
Args |
2011-12-04 09:21:48 | pitrou | set | recipients:
+ pitrou, orsenthil, r.david.murray, Jon.Kuhn |
2011-12-04 09:21:48 | pitrou | set | messageid: <1322990508.04.0.143232096173.issue13464@psf.upfronthosting.co.za> |
2011-12-04 09:20:47 | pitrou | link | issue13464 messages |
2011-12-04 09:20:47 | pitrou | create | |
|