Author neologix
Recipients Arfrever, amaury.forgeotdarc, belopolsky, benjamin.peterson, doko, exarkun, loewis, naufraghi, neologix, petere, pitrou, stutzbach
Date 2011-11-27.10:57:33
SpamBayes Score 3.35888e-05
Marked as misclassified No
Message-id <1322391454.34.0.832001251191.issue7111@psf.upfronthosting.co.za>
In-reply-to
Content
(No Rietveld link):

+is_valid_fd(int fd)
[...]
+    dummy_fd = dup(fd);
+    if (dummy_fd < 0)
+        return 0;
+    close(dummy_fd);

Why not use fstat() instead (does Windows have fstat()? And dup()?).

+    @unittest.skipIf(os.name == 'nt', "test needs POSIX semantics")
+    def test_no_stdin(self):

It would maybe be more direct with skipUnless(os.name == 'posix').

Finally, it's not that important, but it could maybe be possible to factorize the code, i.e. make a helper function that takes a list of streams and defines the preexec() function and code to test those streams, and then just call:

def test_no_stdin(self):
    out, err = self._test_with_closed_streams(['stdin'])
    [...]

def test_no_streams(self):
    out, err = self._test_with_closed_streams(['stdin', 'stdout', 'stderr'])
    [...]
History
Date User Action Args
2011-11-27 10:57:34neologixsetrecipients: + neologix, loewis, doko, exarkun, amaury.forgeotdarc, belopolsky, pitrou, benjamin.peterson, stutzbach, naufraghi, Arfrever, petere
2011-11-27 10:57:34neologixsetmessageid: <1322391454.34.0.832001251191.issue7111@psf.upfronthosting.co.za>
2011-11-27 10:57:33neologixlinkissue7111 messages
2011-11-27 10:57:33neologixcreate