Message148406
> if a line ends with ";;", _pop_values() will call interpret() with an empty string. [...]
> it just means interpret() would return False, causing the line to be ignored, which is probably
> fine for that border case
Hm, I’d rather call that a bug. _pop_values should not call interpret, or interpret('') should return True (there is no condition that fails), or _pop_values should raise an exception (pro: errors should never pass silently, con: it’s not an error if we define that the empty string is a no-op, and it’s more user-friendly to do that). I’m inclined to let interpret(''), do you think it’s sensible? |
|
Date |
User |
Action |
Args |
2011-11-26 14:17:27 | eric.araujo | set | recipients:
+ eric.araujo, tarek, alexis, eli.collins |
2011-11-26 14:17:27 | eric.araujo | set | messageid: <1322317047.65.0.66125206804.issue12424@psf.upfronthosting.co.za> |
2011-11-26 14:17:27 | eric.araujo | link | issue12424 messages |
2011-11-26 14:17:26 | eric.araujo | create | |
|