Message147501
I would say that this one is clear too:
aelf.assertTrue(isinstance(obj, cls))
except that the failure message is not very friendly:
AssertionError: False is not true
If we keep assertIsInstance, more people will continue to misuse it just because the method exist, when they really want to check (type(obj) is cls).
An option could be to add a snippet to the documentation of `assertIsInstance` stating that the right way to check exact type is `assertIs(type(obj), cls)`. |
|
Date |
User |
Action |
Args |
2011-11-12 15:25:41 | flox | set | recipients:
+ flox, georg.brandl, rhettinger, ezio.melotti, eric.araujo, michael.foord |
2011-11-12 15:25:41 | flox | set | messageid: <1321111541.17.0.897829516535.issue13387@psf.upfronthosting.co.za> |
2011-11-12 15:25:40 | flox | link | issue13387 messages |
2011-11-12 15:25:40 | flox | create | |
|