This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author ezio.melotti
Recipients William.Wu, eric.araujo, ezio.melotti, georg.brandl, orsenthil
Date 2011-11-09.02:17:29
SpamBayes Score 4.111862e-08
Marked as misclassified No
Message-id <1320805051.27.0.103623311853.issue11082@psf.upfronthosting.co.za>
In-reply-to
Content
I think the information in the patch should go in the urlopen doc, not in urlencode.  Adding a note to urlencode that says that the result must be encoded is fine, but all the details about the default encoding and the fact that an extra Content-Type header is necessary when the encoding is not iso-8859-1 belong to the urlopen doc IMHO.  (Is the header actually necessary?  I think I always sent utf-8 without header, and the example you added in r88394 also uses utf-8 with no extra headers.)
There are also a few minor issues with the patch -- I'll leave a note in rietveld for that.
History
Date User Action Args
2011-11-09 02:17:31ezio.melottisetrecipients: + ezio.melotti, georg.brandl, orsenthil, eric.araujo, William.Wu
2011-11-09 02:17:31ezio.melottisetmessageid: <1320805051.27.0.103623311853.issue11082@psf.upfronthosting.co.za>
2011-11-09 02:17:30ezio.melottilinkissue11082 messages
2011-11-09 02:17:29ezio.melotticreate