Author sbt
Recipients benjamin.peterson, neologix, petri.lehtinen, pitrou, sbt, stutzbach
Date 2011-11-07.17:52:39
SpamBayes Score 2.26434e-07
Marked as misclassified No
Message-id <1320688361.58.0.902984697592.issue13322@psf.upfronthosting.co.za>
In-reply-to
Content
Testing the patch a bit more thoroughly, I found that data received from the readable end of the pipe can be corrupted by the C implementation.  This seems to be because two of the previously dormant codepaths did not properly maintain the necessary invariants.

I got the failures to go away by adding

        self->pos += avail;

in two places.  However, I really do not know what all the attributes mean.  (Should self->raw_pos also be modified...?)  Someone familiar with the code would need to check whether things are being done properly.  This new patch adds some XXX comments in places  in bufferedio.c which I am unsure about.
History
Date User Action Args
2011-11-07 17:52:41sbtsetrecipients: + sbt, pitrou, benjamin.peterson, stutzbach, neologix, petri.lehtinen
2011-11-07 17:52:41sbtsetmessageid: <1320688361.58.0.902984697592.issue13322@psf.upfronthosting.co.za>
2011-11-07 17:52:41sbtlinkissue13322 messages
2011-11-07 17:52:40sbtcreate