Message146722
If the test suite is run with PYTHONNOUSERSITE=true, the test_s_option test in test_site fails, because it implicitly assumes that site.ENABLE_USER_SITE is True and that site.USER_SITE should unconditionally be in sys.path.
This is a practical problem in the reference implementation for PEP 404, as the tests should pass when run from within a virtual environment, but a system-isolated virtual environment disables user-site (i.e. has the same effect as PYTHONNOUSERSITE).
I think the correct fix here is to conditionally skip that test if site.ENABLE_USER_SITE is not True.
I also think the module-level conditional check at the top of the file, which, if site.USER_SITE does not exist, creates site.USER_SITE and calls site.addsitedir() on it, should only run if site.ENABLE_USER_SITE is True. |
|
Date |
User |
Action |
Args |
2011-10-31 18:31:08 | carljm | set | recipients:
+ carljm |
2011-10-31 18:31:08 | carljm | set | messageid: <1320085868.02.0.130211137087.issue13304@psf.upfronthosting.co.za> |
2011-10-31 18:31:07 | carljm | link | issue13304 messages |
2011-10-31 18:31:07 | carljm | create | |
|