Author mark.dickinson
Recipients ezio.melotti, mark.dickinson, smarnach
Date 2011-10-17.18:23:40
SpamBayes Score 1.43251e-09
Marked as misclassified No
Message-id <1318875821.58.0.166106227933.issue13201@psf.upfronthosting.co.za>
In-reply-to
Content
The new patch looks fine;  I'd still like to have the more explicit reference counting in range_hash (see replies on Rietveld).

A few more things:

- The patch needs a Misc/NEWS entry before committing;  it probably deserves a line in Doc/whatsnew/3.3.rst, too.

- The doc update should have a ".. versionchanged:: 3.3" note.

- Maybe the range_compare function could be renamed to something that makes it clearer it's just doing an equality comparison rather than a generalized comparison.  'range_equality_check'?  Or just 'range_equal' or 'range_equality'?
History
Date User Action Args
2011-10-17 18:23:41mark.dickinsonsetrecipients: + mark.dickinson, ezio.melotti, smarnach
2011-10-17 18:23:41mark.dickinsonsetmessageid: <1318875821.58.0.166106227933.issue13201@psf.upfronthosting.co.za>
2011-10-17 18:23:41mark.dickinsonlinkissue13201 messages
2011-10-17 18:23:40mark.dickinsoncreate