Author paul.moore
Recipients alexis, eric.araujo, paul.moore, tarek, vinay.sajip
Date 2011-10-17.14:28:59
SpamBayes Score 1.78351e-11
Marked as misclassified No
Message-id <CACac1F_oYSCgVhsY=v3r87x1A9jPaSYG1N9WEY7dPLY0gfNjJA@mail.gmail.com>
In-reply-to <1318857312.51.0.756657160129.issue13175@psf.upfronthosting.co.za>
Content
On 17 October 2011 14:15, Éric Araujo <report@bugs.python.org> wrote:
>> The file passed to csv.writer should be opened with newline=''.
> How will we port this to 2.x?

No idea :-( The 2.7 documentation says use the 'b' flag, but that
probably doesn't allow an encoding parameter (it doesn't on 3.x).

>> I don't expect the test will catch the issue except on Windows...
> Do you mean that the test will fail or be a no-op on other OSes?  We can mark it as Windows-specific (@unittest.skipIf(sys.platform != 'win32', 'test only relevant on win32')) or just let it run if it’s harmless.  The important point is: does it fail before the fix, does it pass after?

The test fails before the fix, passes after. It's a no-op on platforms
where text and binary files are the same, (i.e., non-Windows systems).
So it's harmless.
History
Date User Action Args
2011-10-17 14:28:59paul.mooresetrecipients: + paul.moore, vinay.sajip, tarek, eric.araujo, alexis
2011-10-17 14:28:59paul.moorelinkissue13175 messages
2011-10-17 14:28:59paul.moorecreate