Message145700
On 17 October 2011 14:15, Éric Araujo <report@bugs.python.org> wrote:
>> The file passed to csv.writer should be opened with newline=''.
> How will we port this to 2.x?
No idea :-( The 2.7 documentation says use the 'b' flag, but that
probably doesn't allow an encoding parameter (it doesn't on 3.x).
>> I don't expect the test will catch the issue except on Windows...
> Do you mean that the test will fail or be a no-op on other OSes? We can mark it as Windows-specific (@unittest.skipIf(sys.platform != 'win32', 'test only relevant on win32')) or just let it run if it’s harmless. The important point is: does it fail before the fix, does it pass after?
The test fails before the fix, passes after. It's a no-op on platforms
where text and binary files are the same, (i.e., non-Windows systems).
So it's harmless. |
|
Date |
User |
Action |
Args |
2011-10-17 14:28:59 | paul.moore | set | recipients:
+ paul.moore, vinay.sajip, tarek, eric.araujo, alexis |
2011-10-17 14:28:59 | paul.moore | link | issue13175 messages |
2011-10-17 14:28:59 | paul.moore | create | |
|