Message 145336 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	jazzer
Recipients	jazzer, neologix, pitrou
Date	2011-10-11.09:10:54
SpamBayes Score	0.0015838984
Marked as misclassified	No
Message-id	<1318324255.07.0.00919573279465.issue13148@psf.upfronthosting.co.za>
In-reply-to

Content
> You got lucky, since the offset must be a multiple of the page size. That's why our header is exactly the page size :) > Here's what POSIX says Then it's just another discrepancy between POSIX and Linux, as I received ENOMEM instead of EINVAL (RHEL6 on 2.6.32). Regarding the contradiction, it's probably still worth changing the exception message to "mmap offset is greater than _or equal to_ file size", to match the condition. Just 'greater than' means the '>' check, not the '>=' check from the code, mathematically.

> You got lucky, since the offset must be a multiple of the page size.
That's why our header is exactly the page size :)

> Here's what POSIX says
Then it's just another discrepancy between POSIX and Linux, as I received ENOMEM instead of EINVAL (RHEL6 on 2.6.32).


Regarding the contradiction, it's probably still worth changing the exception message to "mmap offset is greater than _or equal to_ file size", to match the condition. Just 'greater than' means the '>' check, not the '>=' check from the code, mathematically.

History
Date	User	Action	Args
2011-10-11 09:10:55	jazzer	set	recipients: + jazzer, pitrou, neologix
2011-10-11 09:10:55	jazzer	set	messageid: <1318324255.07.0.00919573279465.issue13148@psf.upfronthosting.co.za>
2011-10-11 09:10:54	jazzer	link	issue13148 messages
2011-10-11 09:10:54	jazzer	create