This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author mark.dickinson
Recipients alex, ezio.melotti, mark.dickinson, meador.inge, python-dev, terry.reedy
Date 2011-09-24.10:52:30
SpamBayes Score 1.94927e-06
Marked as misclassified No
Message-id <1316861551.62.0.563425870072.issue13012@psf.upfronthosting.co.za>
In-reply-to
Content
Ezio's patch looks fine to me, though as Meador points out in the Rietveld review, there are a couple of omissions that could be fixed.

Personally, I'm not so convinced of the value of upgrading all the existing uses of splitlines to use 'keepends';  I just wanted to be able to do this in *new* code. :-)  I guess I'm +0 on the int -> bool changes (replacing .splitlines(1) with .splitlines(True)), and -0 on adding the extra 'splitlines' keywords throughout existing source.
History
Date User Action Args
2011-09-24 10:52:31mark.dickinsonsetrecipients: + mark.dickinson, terry.reedy, ezio.melotti, alex, meador.inge, python-dev
2011-09-24 10:52:31mark.dickinsonsetmessageid: <1316861551.62.0.563425870072.issue13012@psf.upfronthosting.co.za>
2011-09-24 10:52:31mark.dickinsonlinkissue13012 messages
2011-09-24 10:52:30mark.dickinsoncreate