Author vladris
Recipients amaury.forgeotdarc, brian.curtin, pitrou, tim.golden, vladris
Date 2011-08-27.02:33:55
SpamBayes Score 3.30651e-09
Marked as misclassified No
Message-id <1314412436.38.0.968547268958.issue12802@psf.upfronthosting.co.za>
In-reply-to
Content
I wasn't aware this is an auto-generated file. I can add a comment but looking at it, it seems we auto-generate this file just to save a call to _dosmaperr. I would refactor the whole function to call _dosmaperr first then if result is still EINVAL, tweak with custom switch case. The way I see it, this looks like premature optimization since OS error shouldn't be on a hot code path, meaning an application should be able to live with an extra CRT function call on such exceptions. I'm willing to implement this if  there are no objections. Something like:

errno = _dosmaperr(err)
if (EINVAL == errno)
{
    switch (err)
    {
    // Our tweaks
    }
}
History
Date User Action Args
2011-08-27 02:33:56vladrissetrecipients: + vladris, amaury.forgeotdarc, pitrou, tim.golden, brian.curtin
2011-08-27 02:33:56vladrissetmessageid: <1314412436.38.0.968547268958.issue12802@psf.upfronthosting.co.za>
2011-08-27 02:33:55vladrislinkissue12802 messages
2011-08-27 02:33:55vladriscreate