Message142802
Hm, I don’t think the patch makes the test easier to read or maintain. As I wrote in the commit message for #12721:
> For simple open then read/write calls, I have left the usual idiom
> (with open + read/write), as it is short and readable enough.
In the current tests, sometimes os.path.join is called and the resulting name (e.g. src) is used to write contents and then as argument to a shutil function; I actually prefer that src paths are created right before dst and with similar code.
So I think I’ll reject this patch. |
|
Date |
User |
Action |
Args |
2011-08-23 09:00:51 | eric.araujo | set | recipients:
+ eric.araujo, hynek |
2011-08-23 09:00:51 | eric.araujo | set | messageid: <1314090051.48.0.391365474557.issue12824@psf.upfronthosting.co.za> |
2011-08-23 09:00:50 | eric.araujo | link | issue12824 messages |
2011-08-23 09:00:50 | eric.araujo | create | |
|