This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author jaraco
Recipients brian.curtin, jaraco, pitrou, tim.golden
Date 2011-08-18.14:56:24
SpamBayes Score 3.35721e-05
Marked as misclassified No
Message-id <1313679385.51.0.149765023342.issue12777@psf.upfronthosting.co.za>
In-reply-to
Content
I agree the two calls should probably be consistent, though I also suspect that VOLUME_NAME_NT is always longer than VOLUME_NAME_DOS.

My justification for using VOLUME_NAME_NT is that the final name might not be located on a DOS-accessible name. My suspicion was that VOLUME_NAME_NT was more general purpose (though somewhat less user-friendly), so preferable in the case that the name isn't exposed to the user. It's been a while since I've investigated it, but I think you can have symlinks to UNC paths as well as \\?\ paths, so my concern is VOLUME_NAME_DOS might not work with those paths. Some tests are probably called for.

In the case of nt._getfinalpathname(), it's not obvious to me how it might be used, so VOLUME_NAME_DOS may be more appropriate. Or perhaps _getfinalpathname should pass that parameter through.
History
Date User Action Args
2011-08-18 14:56:25jaracosetrecipients: + jaraco, pitrou, tim.golden, brian.curtin
2011-08-18 14:56:25jaracosetmessageid: <1313679385.51.0.149765023342.issue12777@psf.upfronthosting.co.za>
2011-08-18 14:56:24jaracolinkissue12777 messages
2011-08-18 14:56:24jaracocreate