Author belopolsky
Recipients Rhamphoryncus, amaury.forgeotdarc, belopolsky, doerwalter, eric.smith, ezio.melotti, georg.brandl, lemburg, loewis, pitrou, rhettinger, stutzbach, tchrist, vstinner
Date 2011-08-16.21:59:19
SpamBayes Score 0.000278159
Marked as misclassified No
Message-id <1313531960.45.0.171379272648.issue10542@psf.upfronthosting.co.za>
In-reply-to
Content
The code review links point to something weird.  Victor, can you upload your patch for review?

My first impression is that your patch does not accomplish much beyond replacing some literal expressions with macros.  What I wanted to achieve with this issue was to enable writing code without #ifdef Py_UNICODE_WIDE branches.  In your patch these branches seem to still be there and in fact it appears that new code is longer than the old one (I am not sure why, but I see more '+' than '-'s in your patch.)
History
Date User Action Args
2011-08-16 21:59:20belopolskysetrecipients: + belopolsky, lemburg, loewis, doerwalter, georg.brandl, rhettinger, amaury.forgeotdarc, Rhamphoryncus, pitrou, vstinner, eric.smith, stutzbach, ezio.melotti, tchrist
2011-08-16 21:59:20belopolskysetmessageid: <1313531960.45.0.171379272648.issue10542@psf.upfronthosting.co.za>
2011-08-16 21:59:19belopolskylinkissue10542 messages
2011-08-16 21:59:19belopolskycreate