Author matejcik
Recipients abo, astrand, benjamin.peterson, christian.heimes, collinwinter, djc, dsagal, exarkun, flox, giampaolo.rodola, gjb1002, gregory.p.smith, grossetti, jlamanna, jonash, jyasskin, kanaka, matejcik, nnorwitz, oefe, pitrou, r.david.murray, santoni, shaphiro, siemer, tom_culliton, yonas
Date 2011-08-16.18:21:51
SpamBayes Score 0.000332552
Marked as misclassified No
Message-id <1313518912.35.0.637408824702.issue1731717@psf.upfronthosting.co.za>
In-reply-to
Content
please check my logic here, but the patched code seems to throw away perfectly valid return codes:
in wait(), self._handle_exitstatus(sts) gets called unconditionally, and it resets self.returncode also unconditionally.
now, if a _cleanup() already did _internal_poll and set self.returncode that way, it is lost when wait() catches the ECHILD, in the one place where it actually matters, by setting sts=0 for the _handle_exitstatus call

IMHO it could be fixed by moving _handle_exitstatus to the try: section, and returning "self.returncode or 0" or something like that
History
Date User Action Args
2011-08-16 18:21:52matejciksetrecipients: + matejcik, nnorwitz, collinwinter, abo, gregory.p.smith, astrand, siemer, exarkun, gjb1002, oefe, pitrou, giampaolo.rodola, christian.heimes, dsagal, jyasskin, tom_culliton, benjamin.peterson, djc, grossetti, r.david.murray, yonas, jonash, flox, kanaka, santoni, shaphiro, jlamanna
2011-08-16 18:21:52matejciksetmessageid: <1313518912.35.0.637408824702.issue1731717@psf.upfronthosting.co.za>
2011-08-16 18:21:51matejciklinkissue1731717 messages
2011-08-16 18:21:51matejcikcreate