This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author pitrou
Recipients Arfrever, amaury.forgeotdarc, djc, doko, eric.araujo, ezio.melotti, jwilk, lemburg, loewis, neologix, petri.lehtinen, pitrou, python-dev, r.david.murray, rosslagerwall, vstinner
Date 2011-07-19.23:26:16
SpamBayes Score 1.93231e-08
Marked as misclassified No
Message-id <1311117894.3618.6.camel@localhost.localdomain>
In-reply-to <>
Le mardi 19 juillet 2011 à 23:20 +0000, STINNER Victor a écrit :
> STINNER Victor <> added the comment:
> > Your patch looks fine to me, except for this:
> > -        if (platform in ('linux2', 'freebsd4', 'freebsd5', 'freebsd6',
> > -                        'freebsd7', 'freebsd8')
> > -            or platform.startswith("gnukfreebsd")):
> > +        if os.uname()[0] in ('Linux', 'FreeBSD'):
> > 
> > Why not use platform.system(), to be consistent?
> I'm not sure that thp platform module can be used in 
> (bootstrap issue?). It should be tested.

Why don't you just use platform.startswith? It would avoid introducing
bugs due to subtle differences between uname, platform or
Date User Action Args
2011-07-19 23:26:17pitrousetrecipients: + pitrou, lemburg, loewis, doko, amaury.forgeotdarc, vstinner, jwilk, djc, ezio.melotti, eric.araujo, Arfrever, r.david.murray, neologix, rosslagerwall, python-dev, petri.lehtinen
2011-07-19 23:26:16pitroulinkissue12326 messages
2011-07-19 23:26:16pitroucreate