Author Jajcus
Recipients Jajcus, jcea, pitrou
Date 2011-07-14.07:17:07
SpamBayes Score 5.83211e-07
Marked as misclassified No
Message-id <1310627828.16.0.705829600599.issue12551@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for the quick review. Most of the problems are my oversights.

I am not sure about that:
> And I think get_channel_binding() should raise NotImplementedError in that case.

As the method is supposed to be extensible and 'tls-unique' may be just one of possible channel-binding types, then I think the same exception should be raised in case 'tls-unique' is requested and not implemented and when other, currently not implemented, channel binding type is requested. The get_channel_binding() method itself is always implemented, that is why I wonder if 'ValueError' is no better. Or 'NotImplementedError' for both 'tls-unique not implemented' and 'unknown channel binding'.
History
Date User Action Args
2011-07-14 07:17:08Jajcussetrecipients: + Jajcus, jcea, pitrou
2011-07-14 07:17:08Jajcussetmessageid: <1310627828.16.0.705829600599.issue12551@psf.upfronthosting.co.za>
2011-07-14 07:17:07Jajcuslinkissue12551 messages
2011-07-14 07:17:07Jajcuscreate