➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author thomas.holmes
Recipients alexis, eric.araujo, higery, tarek, thomas.holmes
Date 2011-07-11.14:12:09
SpamBayes Score 3.7768e-05
Marked as misclassified No
Message-id <1310393530.56.0.655680180217.issue12344@psf.upfronthosting.co.za>
In-reply-to
Content 
> See also three comments about style on http://bugs.python.org/review/8668/diff2/2845:3011/7845

I'm not sure I follow? The patch I attached does not violate the style guidelines that you indicate in the comments. The only failing I see is that get_reinitialized_command inside cmd.py does not have a doc string. I was following the path of minimal change, but I will be happy to add one.


Unless I am misunderstanding something about the other style comments I will work up another version with subcommand kwargs, docstring, and tests.

Thanks again Éric
History
Date User Action Args
2011-07-11 14:12:10thomas.holmessetrecipients: + thomas.holmes, tarek, eric.araujo, alexis, higery
2011-07-11 14:12:10thomas.holmessetmessageid: <1310393530.56.0.655680180217.issue12344@psf.upfronthosting.co.za>
2011-07-11 14:12:10thomas.holmeslinkissue12344 messages
2011-07-11 14:12:09thomas.holmescreate