➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author thomas.holmes
Recipients alexis, eric.araujo, higery, tarek, thomas.holmes
Date 2011-07-09.03:21:03
SpamBayes Score 1.0073495e-05
Marked as misclassified No
Message-id <1310181664.29.0.359737758353.issue12344@psf.upfronthosting.co.za>
In-reply-to
Content 
I have made a patch based on your suggestions made to higery, Éric. I have two questions:

1) In Distributions.get_reinitialized_command should the reinitialization of the subcommands also get passed the kwargs? Unfortunately my understanding of the (sub)command flow is not rock solid.

2) What are your thoughts on an effective test for this? This command does not currently have one. I believe I know a simple way to test the new kwargs functionality but if one were to write a test for get_reinitialized_command I think it should probably test the rest of the function as well.

Thoughts?
History
Date User Action Args
2011-07-09 03:21:04thomas.holmessetrecipients: + thomas.holmes, tarek, eric.araujo, alexis, higery
2011-07-09 03:21:04thomas.holmessetmessageid: <1310181664.29.0.359737758353.issue12344@psf.upfronthosting.co.za>
2011-07-09 03:21:03thomas.holmeslinkissue12344 messages
2011-07-09 03:21:03thomas.holmescreate