Author skrah
Recipients jcon, kermode, mark.dickinson, ncoghlan, petri.lehtinen, pitrou, pv, rupole, skrah, teoliphant, vstinner
Date 2011-07-05.10:49:40
SpamBayes Score 1.30416e-06
Marked as misclassified No
Message-id <1309862981.8.0.603839233593.issue10181@psf.upfronthosting.co.za>
In-reply-to
Content
I've uploaded a revised version that addresses several suggestions. I think 
we have agreement on those now:

  - Officially ditch smalltable.

  - Comment static storage fields inside PyMemoryViewObject.

  - Improve refcounting in PyMemoryView_FromBuffer()/PyMemoryView_FromObject().

  - Increment mbuf refcount in memory_getbuf().

  - Create separate sections for managedbuffer and memoryview.


Still open:

  - Update documentation.

  - Should PyManagedBuffer be private to this file? Do we need mbuf_new()?

  - Add test to _testcapimodule.c. I wrote a small test for the problematic
    case in PyMemoryView_GetContiguous(), and it indeed returns an unaltered
    view. I suggest that we leave the NotImplementedError for now and handle
    that in a separate issue.

  - Flag handling.
History
Date User Action Args
2011-07-05 10:49:41skrahsetrecipients: + skrah, teoliphant, mark.dickinson, ncoghlan, rupole, kermode, pitrou, vstinner, pv, jcon, petri.lehtinen
2011-07-05 10:49:41skrahsetmessageid: <1309862981.8.0.603839233593.issue10181@psf.upfronthosting.co.za>
2011-07-05 10:49:41skrahlinkissue10181 messages
2011-07-05 10:49:40skrahcreate