Author ncoghlan
Recipients jcon, kermode, mark.dickinson, ncoghlan, petri.lehtinen, pitrou, pv, rupole, skrah, teoliphant, vstinner
Date 2011-07-04.13:26:46
SpamBayes Score 5.84005e-07
Marked as misclassified No
Message-id <1309786006.8.0.49279994197.issue10181@psf.upfronthosting.co.za>
In-reply-to
Content
Nice work with the patch Stefan - I've added a few review comments (including a suggestion on how to deal with the GetContiguous problem).

One idea that review did prompt is that if we aren't going back to the original object for fresh buffer requests, perhaps we should expose the underlying object as a read-only property of the memoryview objects. That way if the original view is unsuitable (e.g. read-only when a writable buffer is needed) it should be straightforward to go back to the underlying object to request something different.

Another question Stefan raised is whether or not PyMemoryView_FromObject should accept a "flags" argument that it passes on to the underlying "getbuffer" call. I'm inclined to say yes - ideally I'd like to *only* expose PyMemoryView and PyManagedBuffer (rather than GetBuffer/ReleaseBuffer) for the limited API, which means accepting the flags argument for the two higher level interfaces.
History
Date User Action Args
2011-07-04 13:26:46ncoghlansetrecipients: + ncoghlan, teoliphant, mark.dickinson, rupole, kermode, pitrou, vstinner, pv, skrah, jcon, petri.lehtinen
2011-07-04 13:26:46ncoghlansetmessageid: <1309786006.8.0.49279994197.issue10181@psf.upfronthosting.co.za>
2011-07-04 13:26:46ncoghlanlinkissue10181 messages
2011-07-04 13:26:46ncoghlancreate