Author vstinner
Recipients pitrou, vstinner
Date 2011-07-01.10:25:05
SpamBayes Score 5.88189e-05
Marked as misclassified No
Message-id <1309515906.33.0.927447956049.issue12462@psf.upfronthosting.co.za>
In-reply-to
Content
While reading floatsleep() (time.sleep) code for issue #12459, I noticed that the Python signal handler is not called in floatsleep() if a signal interrupted the sleep. Well, it just "works" because the bytecode evaluation loop will call PyErr_CheckSignals() before executing the next instruction (the C signal handler signals calls Py_AddPendingCall whichs signals that the pending call to the eval loop using "eval_breaker"), but it would be better to call it directly.

Attached calls explicitly and immediatly PyErr_CheckSignals() in the sleep and Windows implementations of floatsleep().

It's not really a bug, so I prefer to not touch Python 2.7 and 3.2, only Python 3.3.
History
Date User Action Args
2011-07-01 10:25:06vstinnersetrecipients: + vstinner, pitrou
2011-07-01 10:25:06vstinnersetmessageid: <1309515906.33.0.927447956049.issue12462@psf.upfronthosting.co.za>
2011-07-01 10:25:05vstinnerlinkissue12462 messages
2011-07-01 10:25:05vstinnercreate