Author eric.smith
Recipients amaury.forgeotdarc, djc, eric.smith, mark.dickinson, michael.foord, rhettinger
Date 2011-06-30.10:01:16
SpamBayes Score 3.68725e-07
Marked as misclassified No
Message-id <1309428077.72.0.970355913247.issue12450@psf.upfronthosting.co.za>
In-reply-to
Content
I see the problems as:

1. Given Python's other overhead, we'd need to profile to show an improvement in the speed of this conversion would make a noticeable impact on any import workload.

2. If we want to keep the shortest-float-repr property for all possible doubles, we'd need to use Grisu3 but still keep our existing code for the fallback cases. This is a big increase in the complexity of an already complex piece of code.

I'm not saying don't switch to Grisu2 or use Grisu3 with the fallback to existing code: maybe the speed improvements are worth it, maybe we can say we we can live with 99.5% shortest repr coverage, or maybe the complexity is worth it. I just want to record the issues here.
History
Date User Action Args
2011-06-30 10:01:17eric.smithsetrecipients: + eric.smith, rhettinger, amaury.forgeotdarc, mark.dickinson, djc, michael.foord
2011-06-30 10:01:17eric.smithsetmessageid: <1309428077.72.0.970355913247.issue12450@psf.upfronthosting.co.za>
2011-06-30 10:01:17eric.smithlinkissue12450 messages
2011-06-30 10:01:16eric.smithcreate