Author terry.reedy
Recipients ezio.melotti, lemburg, loewis, python-dev, skrah, terry.reedy, vincent.chute, vstinner
Date 2011-06-20.16:51:34
SpamBayes Score 2.55617e-06
Marked as misclassified No
Message-id <1308588695.44.0.799400947513.issue3067@psf.upfronthosting.co.za>
In-reply-to
Content
Victor, the issue for 3.x, which remains, is to improve the error message. I also suggested a doc change, though I would like Mark or Martin's comments before I would make it.

>But I think that the commit is just useless because we will have to wait until Python 2.7.3 is released, and if you want to support older Python versions, we will have to encode the locale explicitly to ASCII.

Exactly. 'Older versions' includes older versions of 2.7. This is why I suggested that making the change to 2.7 would be a feature addition, which is not permitted for the very reason you give. I think the commit should be reverted.

Certainly, when a another developer says "This patch should be rejected and not committed' after careful review, you should discuss, possibly on pydev, before committing.
History
Date User Action Args
2011-06-20 16:51:35terry.reedysetrecipients: + terry.reedy, lemburg, loewis, vstinner, ezio.melotti, vincent.chute, skrah, python-dev
2011-06-20 16:51:35terry.reedysetmessageid: <1308588695.44.0.799400947513.issue3067@psf.upfronthosting.co.za>
2011-06-20 16:51:34terry.reedylinkissue3067 messages
2011-06-20 16:51:34terry.reedycreate