This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author eric.araujo
Recipients alexis, eric.araujo, jlove, tarek
Date 2011-06-03.16:04:53
SpamBayes Score 1.2668712e-06
Marked as misclassified No
Message-id <1307117097.48.0.869461066234.issue11751@psf.upfronthosting.co.za>
In-reply-to
Content
Hi!  I cleaned up your patch and fixed a bug: you have to call sort before calling remove_duplicates (the result in your patch had two 'a' entries).

> One line was marked as excluded because it was a "this cannot happen"
> error, and I agreed.
How about we add a test to make this it cannot happen and then remove the line?

I also ported it to packaging, the replacement for distutils; I get this failure:

FAIL: test_process_template (__main__.ManifestTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "Lib/packaging/tests/test_manifest.py", line 166, in test_process_template
    action)
AssertionError: PackagingTemplateError not raised by _process_template_line

I haven’t investigated if the test is wrong or the code buggy yet; do you have any insight?
History
Date User Action Args
2011-06-03 16:04:57eric.araujosetrecipients: + eric.araujo, tarek, alexis, jlove
2011-06-03 16:04:57eric.araujosetmessageid: <1307117097.48.0.869461066234.issue11751@psf.upfronthosting.co.za>
2011-06-03 16:04:54eric.araujolinkissue11751 messages
2011-06-03 16:04:54eric.araujocreate