Message 137315 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	neologix
Recipients	jcon, nadeem.vawda, neologix, petri.lehtinen, pitrou, rich-noir
Date	2011-05-30.18:02:05
SpamBayes Score	2.9558447e-05
Marked as misclassified	No
Message-id	<1306778525.99.0.947802293794.issue12021@psf.upfronthosting.co.za>
In-reply-to

Content
The patch looks good to me. In your test, you don't explicitely close the mmap object: it's not a problem with CPython since it will get unmmapped, and the file descriptor - if it's a file-backed mapping - will get closed, as soon as it gets out of scope, but it would be cleaner to close it explicitely with something like self.addCleanup(m.close).

The patch looks good to me.
In your test, you don't explicitely close the mmap object: it's not a problem with CPython since it will get unmmapped, and the file descriptor - if it's a file-backed mapping - will get closed, as soon as it gets out of scope, but it would be cleaner to close it explicitely with something like self.addCleanup(m.close).

History
Date	User	Action	Args
2011-05-30 18:02:06	neologix	set	recipients: + neologix, pitrou, nadeem.vawda, jcon, rich-noir, petri.lehtinen
2011-05-30 18:02:05	neologix	set	messageid: <1306778525.99.0.947802293794.issue12021@psf.upfronthosting.co.za>
2011-05-30 18:02:05	neologix	link	issue12021 messages
2011-05-30 18:02:05	neologix	create