Author pitrou
Recipients pitrou, vstinner
Date 2011-05-25.15:20:50
SpamBayes Score 0.00257779
Marked as misclassified No
Message-id <1306336851.45.0.175710284572.issue12175@psf.upfronthosting.co.za>
In-reply-to
Content
About rawiobase_readall.patch: why do you use PyObject_Size() if you know chunks is a list? PyList_GET_SIZE is much more efficient.

About bufferedreader_readall.patch:

+            PyBytes_Concat(&data, all);
+            if (data == NULL)
+                return NULL;

You must Py_DECREF(all) first.

Also, you should check that "all" is either None or a bytes object.
History
Date User Action Args
2011-05-25 15:20:51pitrousetrecipients: + pitrou, vstinner
2011-05-25 15:20:51pitrousetmessageid: <1306336851.45.0.175710284572.issue12175@psf.upfronthosting.co.za>
2011-05-25 15:20:50pitroulinkissue12175 messages
2011-05-25 15:20:50pitroucreate