Message 136817 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	vstinner
Recipients	benjamin.peterson, exarkun, gregory.p.smith, jcea, loewis, marcin.bachry, neologix, pitrou, python-dev, schmichael, skrah, spiv, tseaver, vstinner
Date	2011-05-25.00:42:09
SpamBayes Score	6.5488716e-06
Marked as misclassified	No
Message-id	<1306284130.58.0.679849115971.issue8407@psf.upfronthosting.co.za>
In-reply-to

Content
> There's a race. If a signal is received while is_tripped is set, > the signal number won't be written to the wakeup FD. Oh, nice catch. The "bug" is not new, Python behaves like that since Python 3.1. But in Python < 3.3, it doesn't mater because I don't think that wakeup was used to watch more than one signal. One trigger "something happened" was enough. The wakeup fd now contains the number of each signal, and so the behaviour has to change. I applied your patch and I added a test.

> There's a race. If a signal is received while is_tripped is set, 
> the signal number won't be written to the wakeup FD.

Oh, nice catch. The "bug" is not new, Python behaves like that since Python 3.1. But in Python < 3.3, it doesn't mater because I don't think that wakeup was used to watch more than one signal. One trigger "something happened" was enough.

The wakeup fd now contains the number of each signal, and so the behaviour has to change. I applied your patch and I added a test.

History
Date	User	Action	Args
2011-05-25 00:42:10	vstinner	set	recipients: + vstinner, loewis, gregory.p.smith, jcea, spiv, exarkun, tseaver, pitrou, benjamin.peterson, marcin.bachry, schmichael, skrah, neologix, python-dev
2011-05-25 00:42:10	vstinner	set	messageid: <1306284130.58.0.679849115971.issue8407@psf.upfronthosting.co.za>
2011-05-25 00:42:10	vstinner	link	issue8407 messages
2011-05-25 00:42:09	vstinner	create