This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author benjamin.peterson
Recipients benjamin.peterson, neologix, pitrou, python-dev, ryan003, victorpoluceno, vstinner
Date 2011-05-24.17:51:44
SpamBayes Score 1.1363562e-09
Marked as misclassified No
Message-id <BANLkTikStr6OD2vhwS1fa5F0tDBgM32xCw@mail.gmail.com>
In-reply-to <1306259072.9.0.765413481894.issue5715@psf.upfronthosting.co.za>
Content
2011/5/24 Charles-François Natali <report@bugs.python.org>:
>
> Charles-François Natali <neologix@free.fr> added the comment:
>
>> You change caused test_socketserver to hang. I attempted a fix, but I'm not sure if it's completely correct.
>
> I'm a morron.
> I don't know how I could miss this: closing the server socket is perfectly fine in TCP, since a new one is returned by accept(). But in UDP, it's definitely wrong, since it's used by the handler.
> I don't know however how I missed this, since I remember having run test_socketserver...
>
> The best fix is simply to revert the patch.

Done.

> I'm really sorry about this...

Don't worry. It's a bit of a rite of passage for new developers to
break the buildbots. :)
History
Date User Action Args
2011-05-24 17:51:45benjamin.petersonsetrecipients: + benjamin.peterson, pitrou, vstinner, ryan003, victorpoluceno, neologix, python-dev
2011-05-24 17:51:44benjamin.petersonlinkissue5715 messages
2011-05-24 17:51:44benjamin.petersoncreate