Message136760
Justin,
The patch and logic is okay. We can have this is 3.3.
- I find that loop_actions as not appropriate name for the new method. It fails to give a intuitive meaning of what is supposed to do. request_action, request_action_continued or anything else which gives a meaning should be helpful. I agree with your reasoning to provide some flexiblity for the user to override this.
- The patch lacks Documentation and tests should be added to Lib/test/test_socketserver.py. If you can, please append the patch with these, otherwise I shall do it.
A suggestion for better method name is a must! :)
Thanks! |
|
Date |
User |
Action |
Args |
2011-05-24 16:12:17 | orsenthil | set | recipients:
+ orsenthil, gregory.p.smith, giampaolo.rodola, jwarkentin |
2011-05-24 16:12:16 | orsenthil | set | messageid: <1306253536.92.0.914901001629.issue11109@psf.upfronthosting.co.za> |
2011-05-24 16:12:16 | orsenthil | link | issue11109 messages |
2011-05-24 16:12:16 | orsenthil | create | |
|