Author ezio.melotti
Recipients eric.araujo, ezio.melotti, l0nwlf, lemburg, maker, r.david.murray
Date 2011-05-21.22:51:59
SpamBayes Score 7.02721e-06
Marked as misclassified No
Message-id <1306018319.76.0.231648422245.issue8898@psf.upfronthosting.co.za>
In-reply-to
Content
The patch looks ok to me.
AFAIU the lookup will take care to normalize the name and return latin_N.  This also implies that other names (like 'latin-N', 'LaTiN~~N' and so on) will be normalized to latin_N and then accepted.

Regarding the tests, I don't see tests for the aliases anywhere, so something like:
for alias, codec_name in encodings.aliases.items():
    self.assertEqual(codecs.lookup(alias).name, codec_name)
could be added somewhere to check that all the aliases in the dict map to the correct codec.
History
Date User Action Args
2011-05-21 22:51:59ezio.melottisetrecipients: + ezio.melotti, lemburg, eric.araujo, r.david.murray, l0nwlf, maker
2011-05-21 22:51:59ezio.melottisetmessageid: <1306018319.76.0.231648422245.issue8898@psf.upfronthosting.co.za>
2011-05-21 22:51:59ezio.melottilinkissue8898 messages
2011-05-21 22:51:59ezio.melotticreate