Message136488
The patch looks ok to me.
AFAIU the lookup will take care to normalize the name and return latin_N. This also implies that other names (like 'latin-N', 'LaTiN~~N' and so on) will be normalized to latin_N and then accepted.
Regarding the tests, I don't see tests for the aliases anywhere, so something like:
for alias, codec_name in encodings.aliases.items():
self.assertEqual(codecs.lookup(alias).name, codec_name)
could be added somewhere to check that all the aliases in the dict map to the correct codec. |
|
Date |
User |
Action |
Args |
2011-05-21 22:51:59 | ezio.melotti | set | recipients:
+ ezio.melotti, lemburg, eric.araujo, r.david.murray, l0nwlf, maker |
2011-05-21 22:51:59 | ezio.melotti | set | messageid: <1306018319.76.0.231648422245.issue8898@psf.upfronthosting.co.za> |
2011-05-21 22:51:59 | ezio.melotti | link | issue8898 messages |
2011-05-21 22:51:59 | ezio.melotti | create | |
|