Author ezio.melotti
Recipients benjamin.peterson, bob.ippolito, doerwalter, ezio.melotti, fdrake, jowillia, pitrou, rhettinger, xuanji
Date 2011-05-12.22:35:35
SpamBayes Score 2.04105e-08
Marked as misclassified No
Message-id <1305239736.16.0.136374007773.issue5723@psf.upfronthosting.co.za>
In-reply-to
Content
With this approach is necessary to exclude the base class from the tests, either by listing all the Python/C tests explicitly or doing some automatic check to find these base classes.  Listing all the tests is a bad idea because it needs to be updated manually and it's easy to forget about that and end up with tests that are never run.  Checking and skipping the base classes is not very elegant IMHO.

It also requires an extra base class, and even if it's more flexible because it makes possible to add Python-specific tests easily, that's not necessary with json because all the tests run unchanged on both pyjson and cjson.
History
Date User Action Args
2011-05-12 22:35:36ezio.melottisetrecipients: + ezio.melotti, fdrake, doerwalter, rhettinger, bob.ippolito, pitrou, benjamin.peterson, jowillia, xuanji
2011-05-12 22:35:36ezio.melottisetmessageid: <1305239736.16.0.136374007773.issue5723@psf.upfronthosting.co.za>
2011-05-12 22:35:35ezio.melottilinkissue5723 messages
2011-05-12 22:35:35ezio.melotticreate