Author pitrou
Recipients benjamin.peterson, bob.ippolito, doerwalter, ezio.melotti, fdrake, jowillia, pitrou, rhettinger, xuanji
Date 2011-05-12.11:31:53
SpamBayes Score 8.47078e-05
Marked as misclassified No
Message-id <1305199914.15.0.548218427237.issue5723@psf.upfronthosting.co.za>
In-reply-to
Content
Comments:
- I don't like the fact that skip_unless_cjson() uses unittest internals. Why can't you write something like:
   skip_unless_cjson = skipUnless(...)

- instead of "self.mod", "self.json" would be nicer

- you could also export "self.loads", "self.dumps" for easier access

- you could also have two base classes exporting all this instead of repeating the attribute-setting for every test class
History
Date User Action Args
2011-05-12 11:31:54pitrousetrecipients: + pitrou, fdrake, doerwalter, rhettinger, bob.ippolito, benjamin.peterson, ezio.melotti, jowillia, xuanji
2011-05-12 11:31:54pitrousetmessageid: <1305199914.15.0.548218427237.issue5723@psf.upfronthosting.co.za>
2011-05-12 11:31:53pitroulinkissue5723 messages
2011-05-12 11:31:53pitroucreate