Author neologix
Recipients benjamin.peterson, exarkun, gregory.p.smith, loewis, marcin.bachry, neologix, pitrou, python-dev, schmichael, spiv, tseaver, vstinner
Date 2011-05-06.08:47:04
SpamBayes Score 7.79682e-07
Marked as misclassified No
Message-id <1304671625.07.0.400528610424.issue8407@psf.upfronthosting.co.za>
In-reply-to
Content
Oops.
Victor, my mouse got stuck and I mistakenly removed your pending_signals-2 patch. I'm really sorry about this, could you re-post it?

To try to make up for this, a small comment:
In signal_sigwait, at the end of the function,  you do this:

    /* call the signal handler (if any) */
    if (PyErr_CheckSignals())
        return NULL;

I'm not sure I get this: sigwait is used to handle signals synchronously, and in the POSIX semantic, it's incompatible with signal handlers:

"""
sigwait suspends the calling thread until one of the signals in set is delivered to the calling thread. It then stores the number of the signal received in the location pointed to by sig and returns. The signals in set must be blocked and not ignored on entrance to sigwait. If the delivered signal has a signal handler function attached, that function is *not* called.
"""

and
"""
The effect of sigwait() on the signal actions for the signals in set is unspecified.
"""

So, if anything, you shouldn't check for a pending signal.
History
Date User Action Args
2011-05-06 08:47:05neologixsetrecipients: + neologix, loewis, gregory.p.smith, spiv, exarkun, tseaver, pitrou, vstinner, benjamin.peterson, marcin.bachry, schmichael, python-dev
2011-05-06 08:47:05neologixsetmessageid: <1304671625.07.0.400528610424.issue8407@psf.upfronthosting.co.za>
2011-05-06 08:47:04neologixlinkissue8407 messages
2011-05-06 08:47:04neologixcreate