Author eli.bendersky
Recipients docs@python, eli.bendersky, ezio.melotti, georg.brandl, giampaolo.rodola, ncoghlan, sandro.tosi, terry.reedy
Date 2011-05-06.06:28:27
SpamBayes Score 1.63566e-07
Marked as misclassified No
Message-id <1304663311.37.0.309903332154.issue11015@psf.upfronthosting.co.za>
In-reply-to
Content
Terry,

I've incorporated your suggestions except the new formulation for verbosity to doctest.testmod, since it's not really clear which one is more accurate. I think it's intelligible as it is now (especially given that test.support is for use of Python contributors, and not random users). If you have strong preferences about it, feel free to commit another formulation.

Ezio,

I answered your comments in the code review tool.
Regarding the use of assertEqual for the floating point results, I just didn't want to rely on the exact representation of these values. I'm not 100% sure Python ensures this is true on all platforms it supports. Recall that I was just replacing the fcmp code which did basically the same, also not comparing exactly.

----

I will commit a fixed patch to default. I see no reason to backport this since test.support is just a tool for core-devs and contributors and is mainly used for future developments.
History
Date User Action Args
2011-05-06 06:28:31eli.benderskysetrecipients: + eli.bendersky, georg.brandl, terry.reedy, ncoghlan, giampaolo.rodola, ezio.melotti, sandro.tosi, docs@python
2011-05-06 06:28:31eli.benderskysetmessageid: <1304663311.37.0.309903332154.issue11015@psf.upfronthosting.co.za>
2011-05-06 06:28:27eli.benderskylinkissue11015 messages
2011-05-06 06:28:27eli.benderskycreate