Message134920
Thanks for the patch. Some preliminary comments:
- the OpenSSL functions you are using (SSL_get_srp_username etc.) don't seem documented on openssl.org; this makes it harder to do a proper review
- no need to fill Misc/ACKS and Misc/NEWS by yourself, we can take care of that
- what is an "SRP vbase"? is it something standardized, or OpenSSL-specific?
- if server-side support needs a callback, I think it would be better to let users write their callback in Python, rather than force a hardwired implementation
- ssl.wrap_socket() is the legacy API, I would rather add new features only to the SSLContext API |
|
Date |
User |
Action |
Args |
2011-05-01 19:19:21 | pitrou | set | recipients:
+ pitrou, jcea, orsenthil, debatem1, sqs |
2011-05-01 19:19:21 | pitrou | set | messageid: <1304277561.65.0.17265754531.issue11943@psf.upfronthosting.co.za> |
2011-05-01 19:19:20 | pitrou | link | issue11943 messages |
2011-05-01 19:19:20 | pitrou | create | |
|