Author pitrou
Recipients bquinlan, dmalcolm, jnoller, kristjan.jonsson, lukasz.langa, neologix, pitrou, sandro.tosi, ysj.ray
Date 2011-04-27.15:46:37
SpamBayes Score 9.55414e-06
Marked as misclassified No
Message-id <1303919170.3591.7.camel@localhost.localdomain>
In-reply-to <1303918950.18.0.0771320633678.issue10517@psf.upfronthosting.co.za>
Content
> > Thank you. I like this patch, except that _PyGILState_ReInit() should be
> > declared in the appropriate .h file, not in signalmodule.c.
> 
> I asked myself this question when writing the patch: what's the
> convention  regarding functions ? Should they always be declared in a
> header with PyAPI_FUNC, or should this be reserved to functions
> exported through the API?

IMO they should always be exposed in header files. It makes them easier
to discover and re-use than with some "extern" decls sprinkled in .c
files. As for PyAPI_FUNC, I think we always use it out of convention,
although it's probably not useful for private API functions.
History
Date User Action Args
2011-04-27 15:46:38pitrousetrecipients: + pitrou, bquinlan, kristjan.jonsson, jnoller, dmalcolm, sandro.tosi, ysj.ray, neologix, lukasz.langa
2011-04-27 15:46:37pitroulinkissue10517 messages
2011-04-27 15:46:37pitroucreate