Author ncoghlan
Recipients amaury.forgeotdarc, benjamin.peterson, daniel.urban, georg.brandl, gvanrossum, ncoghlan, pwerneck, rodsenra, terry.reedy
Date 2011-04-21.16:46:51
SpamBayes Score 1.38356e-08
Marked as misclassified No
Message-id <1303404412.87.0.927317413989.issue1294232@psf.upfronthosting.co.za>
In-reply-to
Content
Commenting on the latest patch here, since the Rietveld integration isn't coping with the "hg extdiff" output (I would guess that the revision numbers in the pathnames are confusing the script that attempts to determine the base revision).

Aside from the note above about needing to restore the special case handling for non-type metaclasses, the only other recommendation I have is for the new metaclass invocation tests to add a second metaclass to the hierarchy and explicitly check the order of the __new__ calls, as in the original examples above that invoked the wrong M_A/M_B/M_A sequence. Those tests will then also be applicable to Python 2.7 (which doesn't have __prepare___).
History
Date User Action Args
2011-04-21 16:46:52ncoghlansetrecipients: + ncoghlan, gvanrossum, georg.brandl, terry.reedy, amaury.forgeotdarc, rodsenra, pwerneck, benjamin.peterson, daniel.urban
2011-04-21 16:46:52ncoghlansetmessageid: <1303404412.87.0.927317413989.issue1294232@psf.upfronthosting.co.za>
2011-04-21 16:46:51ncoghlanlinkissue1294232 messages
2011-04-21 16:46:51ncoghlancreate