Message134128
>> I'm not sure it is necessary to use TempdirManager here to write tests
>> for MANIFEST reading.
>Well, the sdist command has to run on some directory where some files >exist, right? So it’s better to do it in a temp dir that will automatically get >cleaned up.
Because the MANIFEST file finally will be filled with file-paths which takes '/' as path separator and that's what we can make sure if we already hacked the write_manifest function in sdist.py, so we can just write the imitated paths strings into the MANIFEST file , not needing to really create these files at first. As a test, it makes sense. So, I think we maynot need to use TempdirManager here.
>> Bad effect is MANIFEST file will be re-written:
>You should read the docs for MANIFEST and sdist: a MANIFEST without >the magic comment will not get overwritten (unless there’s a bug :)
Oh, you are right. Thus this bad effect would not exist for this test. But future discussing is still needed. |
|
Date |
User |
Action |
Args |
2011-04-20 07:48:30 | higery | set | recipients:
+ higery, jhylton, tarek, eric.araujo, santoso.wijaya |
2011-04-20 07:48:30 | higery | set | messageid: <1303285710.44.0.89771998196.issue828450@psf.upfronthosting.co.za> |
2011-04-20 07:48:29 | higery | link | issue828450 messages |
2011-04-20 07:48:29 | higery | create | |
|