Message134078
> I'm not sure it is necessary to use TempdirManager here to write tests
> for MANIFEST reading.
Well, the sdist command has to run on some directory where some files exist, right? So it’s better to do it in a temp dir that will automatically get cleaned up.
> Bad effect is MANIFEST file will be re-written:
You should read the docs for MANIFEST and sdist: a MANIFEST without the magic comment will not get overwritten (unless there’s a bug :) |
|
Date |
User |
Action |
Args |
2011-04-19 16:53:45 | eric.araujo | set | recipients:
+ eric.araujo, jhylton, tarek, santoso.wijaya, higery |
2011-04-19 16:53:45 | eric.araujo | set | messageid: <1303232025.22.0.505576927402.issue828450@psf.upfronthosting.co.za> |
2011-04-19 16:53:43 | eric.araujo | link | issue828450 messages |
2011-04-19 16:53:43 | eric.araujo | create | |
|