This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author higery
Recipients eric.araujo, higery, jhylton, santoso.wijaya, tarek
Date 2011-04-19.16:49:18
SpamBayes Score 4.284028e-05
Marked as misclassified No
Message-id <1303231763.95.0.492689812537.issue828450@psf.upfronthosting.co.za>
In-reply-to
Content
I'm not sure it is necessary to use TempdirManager here to write tests for MANIFEST reading.
The attachment is the test diff file against my last patch with the latest version.

Detail:
Step 1: Write sample MANIFEST strings to the MANIFEST file with '/' as separator and get the filelist of this file(actually just created from the sample strings)
Step 2: Change the os.sep to '\' and then run the sdist command, and a FileList will be generated. Bad effect is MANIFEST file will be re-written: write_manifest function called(method calling route: run->get_file_list->write_manifest). Because the content in MANIFEST has already been changed, we can just use the FileList object to get the filelist, instead of construct it from reading MANIFEST file again as other tests do.
Step 3: Compare filelist_1 generated in Step1 with filelist_2 in Step2, making sure that we have replace '\' with '/' for filelist_2. Yes, we just compare the content to make sure that we has done right thing and reading MANIFEST file with '/' as separator on the platform which os.sep is '\' is ok.

That's all.
History
Date User Action Args
2011-04-19 16:49:24higerysetrecipients: + higery, jhylton, tarek, eric.araujo, santoso.wijaya
2011-04-19 16:49:23higerysetmessageid: <1303231763.95.0.492689812537.issue828450@psf.upfronthosting.co.za>
2011-04-19 16:49:18higerylinkissue828450 messages
2011-04-19 16:49:18higerycreate